Are multiple asserts bad in a unit test? Even if chaining?

Posted by Michael Haren on Stack Overflow See other posts from Stack Overflow or by Michael Haren
Published on 2010-03-12T04:03:36Z Indexed on 2010/03/12 4:07 UTC
Read the original article Hit count: 173

Filed under:

unit-testing

|

mstest

|

c#

|

asp.net-mvc-2

Is there anything wrong with checking so many things in this unit test?:

ActualModel = ActualResult.AssertViewRendered()        // check 1
                          .ForView("Index")            // check 2
                          .WithViewData<List<Page>>(); // check 3

CollectionAssert.AreEqual(Expected, ActualModel);      // check 4

The primary goals of this test are to verify the right view is returned (check 2) and it contains the right data (check 4).

Would I gain anything by splitting this into multiple tests? I'm all about doing things right, but I'm not going to split things up if it doesn't have practical value.

I'm pretty new to unit testing, so be gentle.

© Stack Overflow or respective owner

Related posts about unit-testing

Unit testing best practices for a unit testing newbie

as seen on Programmers - Search for 'Programmers'
In recent years, I have only written small components for people in larger projects or small tools. I have never written a unit test and it always seems like learning how to write them and actually making one takes a lot longer than simply firing up the program and testing for real. I am just about… >>> More
About unit testing a function in the zend framework and unit testing in general

as seen on Stack Overflow - Search for 'Stack Overflow'
Hello people, I am diving into the world of unit testing. And i am sort of lost. I learned today that unit testing is testing if a function works. I wanted to test the following function: public function getEventById($id) { return $this->getResource('Event')->getEventById($id); } So… >>> More
Unit testing a database connection and general questions on database-dependent code and unit testing

as seen on Stack Overflow - Search for 'Stack Overflow'
Hi, If I have a method which establishes a database connection, how could this method be tested? Returning a bool in the event of a successful connection is one way, but is that the best way? From a testability method, is it best to have the connection method as one method and the method to get… >>> More
What is the objective of unit testing?

as seen on Programmers - Search for 'Programmers'
I've been working with C# for the last 2 years, and I've never done any unit testing. I just need to know what the objective of unit testing is. What kind of results do we expect from unit testing? Is code quality checked by unit testing? In my view, unit testing is the job of testers; if that is… >>> More
Unit testing newbie team needs to unit test

as seen on Programmers - Search for 'Programmers'
I'm working with a new team that has historically not done ANY unit testing. My goal is for the team to eventually employ TDD (Test Driven Development) as their natural process. But since TDD is such a radical mind shift for a non-unit testing team I thought I would just start off with writing unit… >>> More

Related posts about mstest

WatiN in MSTest - ClassCleanup fail

as seen on Stack Overflow - Search for 'Stack Overflow'
In thread WatiN in Visual Studio 2008 - second test method fails (http://stackoverflow.com/questions/679347/watin-in-visual-studio-2008-second-test-method-fails) there is a good solution with IEStaticInstanceHelper (original answer Reusing an IE instance in VS test, sources [http://cid-7a759edaf62c1f79… >>> More
TFS 2010 RC does not run Visual Studio 2008 MSTest unit tests

as seen on Stack Overflow - Search for 'Stack Overflow'
Steps: Run the build including unit tests. Expected result: the unit tests are executed and succeed. Actual result: the unit tests are built by the build, but this is the result: 1 test run(s) completed - 0% average pass rate (0% total pass rate) 0/4 test(s) passed, 0 failed, 4 … >>> More
First Test Crashes using MSTEST with ASP.NET MVC 1

as seen on Stack Overflow - Search for 'Stack Overflow'
I'm trying to start using Unit Testing and I want to test the following Controller: public class AjaxController : Controller { ... public JsonResult RateVideo( int userRating, long videoId ) { string userName = User.Identity.Name; ... } } I have a created a TestClass… >>> More
MSTEST CollectionAssert use with generics?

as seen on Stack Overflow - Search for 'Stack Overflow'
It appears that CollectionAssert cannot be used with generics. This is super frustrating; the code I want to test does use generics. What am I to do? Write boilerplate to convert between the two? Manually check collection equivalence? >>> More
Solution: Testing Web Services with MSTest on Team Build

as seen on Geeks with Blogs - Search for 'Geeks with Blogs'
Guess what. About 20 minutes after I fixed the build, Allan broke it again! Update: 4th March 2010 – After having huge problems getting this working I read Billy Wang’s post which showed me the light. The problem here is that even though the test passes locally it will not during an Automated… >>> More