What should be done first: Code reviews or Unit tests?

Posted by goldenmean on Stack Overflow See other posts from Stack Overflow or by goldenmean
Published on 2009-02-09T06:26:48Z Indexed on 2010/03/26 14:43 UTC
Read the original article Hit count: 320

Filed under:

code-review

|

unit-testing

|

subjective

Hello,

If a developer implements code for some module and wants to get it reviewed. What should be the order :

*First unit test the module after designing test cases for the module, debugging and fixing the bugs and then give the modified code for peer code review

(Pros- Code to be reviewed is 'clean' to a good extent. Reduces some avoidable review comments and rework. Cons- Developer might spend large time debugging/fixing a bug which could have pointed/anticipated in peer code reviews)

Or

*First do the code review with peers and then go for unit testing.

What are your thoughts/experience on this?

I believe this approach for unit testing, code reviewing should be programming language agnostic, but it would be interesting to know otherwise(if applicable) with specific examples.

-AD

© Stack Overflow or respective owner

Related posts about code-review

code review: Is it subjective or objective(quantifiable) ?

as seen on Stack Overflow - Search for 'Stack Overflow'
I am putting together some guidelines for code reviews. We do not have one formal process yet, and trying to formalize it. And our team is geographically distributed We are using TFS for source control (used it for tasks/bug tracking/project management as well, but migrated that to JIRA) with VS2008… >>> More
What's a good desktop-based code review tool?

as seen on Stack Overflow - Search for 'Stack Overflow'
Is there a desktop-based tool that's used for code reviews or do we just have to print out the code and mark it up by hand? >>> More
Using commit monitors as a form of code review

as seen on Stack Overflow - Search for 'Stack Overflow'
I'm working in a small company - four developers, working on a variety of projects. We've been looking at what we can do as cost-effective methods of process improvement, and an idea came up. Given what we do, we often have single developers working on parts of a system, independently of the other… >>> More
VS 2012 Code Review – Before Check In OR After Check In?

as seen on Geeks with Blogs - Search for 'Geeks with Blogs'
“Is Code Review Important and Effective?” There is a consensus across the industry that code review is an effective and practical way to collar code inconsistency and possible defects early in the software development life cycle. Among others some of the advantages of code reviews are, Bugs… >>> More
Why should i depend on a tool for my code review?

as seen on Stack Overflow - Search for 'Stack Overflow'
I have done with my web application. Now I am into code review phase. I have looked for some tools for code review in StackOverflow. But my question is: Why should I depend on a tool for my code review? >>> More

Related posts about unit-testing

Unit testing best practices for a unit testing newbie

as seen on Programmers - Search for 'Programmers'
In recent years, I have only written small components for people in larger projects or small tools. I have never written a unit test and it always seems like learning how to write them and actually making one takes a lot longer than simply firing up the program and testing for real. I am just about… >>> More
About unit testing a function in the zend framework and unit testing in general

as seen on Stack Overflow - Search for 'Stack Overflow'
Hello people, I am diving into the world of unit testing. And i am sort of lost. I learned today that unit testing is testing if a function works. I wanted to test the following function: public function getEventById($id) { return $this->getResource('Event')->getEventById($id); } So… >>> More
Unit testing a database connection and general questions on database-dependent code and unit testing

as seen on Stack Overflow - Search for 'Stack Overflow'
Hi, If I have a method which establishes a database connection, how could this method be tested? Returning a bool in the event of a successful connection is one way, but is that the best way? From a testability method, is it best to have the connection method as one method and the method to get… >>> More
What is the objective of unit testing?

as seen on Programmers - Search for 'Programmers'
I've been working with C# for the last 2 years, and I've never done any unit testing. I just need to know what the objective of unit testing is. What kind of results do we expect from unit testing? Is code quality checked by unit testing? In my view, unit testing is the job of testers; if that is… >>> More
Unit testing newbie team needs to unit test

as seen on Programmers - Search for 'Programmers'
I'm working with a new team that has historically not done ANY unit testing. My goal is for the team to eventually employ TDD (Test Driven Development) as their natural process. But since TDD is such a radical mind shift for a non-unit testing team I thought I would just start off with writing unit… >>> More