Redundant code constructs

Posted by Diomidis Spinellis on Stack Overflow See other posts from Stack Overflow or by Diomidis Spinellis
Published on 2008-09-26T12:45:13Z Indexed on 2010/05/12 7:24 UTC
Read the original article Hit count: 203

Filed under:

beginner

|

coding-style

The most egregiously redundant code construct I often see involves using the code sequence

if (condition)
    return true;
else
    return false;

instead of simply writing

return (condition);

I've seen this beginner error in all sorts of languages: from Pascal and C to PHP and Java. What other such constructs would you flag in a code review?

© Stack Overflow or respective owner

Related posts about beginner

assembly registers beginner

as seen on Stack Overflow - Search for 'Stack Overflow'
So I've been getting into a bit of assembly lately and I'm a beginner so i was wondering if someone could clarify something. I take it every process has it's own set of registers, and each thread can modify these registers right?. How then do multiple threads use the same registers without causing… >>> More
Beginner learning assembly preserving esp after function calls

as seen on Stack Overflow - Search for 'Stack Overflow'
I'm a beginner learning some assembly, when preserving the ESP register before a function call does it matter if you do it by adding or subtracting? hard to explain, consider the following mov esi, esp sub esp, 12 // on 32bit OS this would mean that there are 3 arguments to the function // push,… >>> More
I am a beginner to C and this is the dumbest question..Confused about getchar() function

as seen on Stack Overflow - Search for 'Stack Overflow'
Sorry if I am not supposed to post beginner level questions here..I am new to this site Please read the code below first I am confused about getchar() 's role in the following code.. I mean I know its helping me see the output window which will only be closed when I press enter key So getchar()… >>> More
Top 10 Reasons SQL Developer is Perfect for Oracle Beginners

as seen on Oracle Blogs - Search for 'Oracle Blogs'
Learning new technologies can be daunting. If you’ve never used a Mac before, you’ll probably be a bit baffled at first. But, you’re probably at least coming from a desktop computing background (Windows), so you common frame of reference. But what if you’re just now learning… >>> More
Would you recommend Head First Programming for someone new?

as seen on Programmers - Search for 'Programmers'
My brother is just starting out college. He's studying the same thing I am here in Bolivia; Systems Engineer which is the equivalent of what a CS degree is in the US. Being his big brother and a programmer myself I really want to guide him and give him the right material to learn and become good… >>> More

Related posts about coding-style

Which coding style is more common?

as seen on Stack Overflow - Search for 'Stack Overflow'
In no way shape or form am i advertising/promoting my programming style, but as far as 'multiple variable declarations' are concerned, which case is more acceptable professionally and commonly: case 1: private $databaseURL = "localhost" ; private $databaseUName = "root" ; private $databasePWord… >>> More
Is my javascript coding style following best-practice?

as seen on Stack Overflow - Search for 'Stack Overflow'
What is the 'best practise' with regard to coding style. Should I use _ for private members? Should I use this._privateMember? Please re-write my code in proper style if its wrong: (function()){ var _blah = 1; someFunction = function() { alert(_blah); }; someOtherFunction… >>> More
Java coding style

as seen on Stack Overflow - Search for 'Stack Overflow'
How do you keep yourself coding to standards? There is stylecop and resharper for C#. Are there any tools/eclipse plugins for code analisys in Java? Which of them do you use? >>> More
Common coding style for Python?

as seen on Stack Overflow - Search for 'Stack Overflow'
Hi, I'm pretty new to Python, and I want to develop my first serious open source project. I want to ask what is the common coding style for python projects. I'll put also what I'm doing right now. 1.- What is the most widely used column width? (the eternal question) I'm currently sticking to 80… >>> More
Have you changed your coding style recently? It wasn't hard wasn't it?

as seen on Programmers - Search for 'Programmers'
I've used to write code in C-like languages using the Allman style, regarding the position of braces. void foo(int bar) { if(bar) { //... } else return; //... } Now the last two years I have been working mostly in JavaScript and when we adopted jslint as part of our QA process… >>> More