C# Code Smells. What are the most common and how to fix them?

Posted by Carlos Loth on Stack Overflow See other posts from Stack Overflow or by Carlos Loth
Published on 2010-05-25T10:00:43Z Indexed on 2010/05/25 10:01 UTC
Read the original article Hit count: 262

Filed under:

c#

|

code-review

Hi,

One thing I'd like to hear from you guys is what are the code smells that you see most often happen on C# code and how to fix them. I'm working on defining a code-review process for my team and I'd like to include a section with the most common C# code smells and a possible fix for each of them. I'd like the assistance of the community on that, so others can reuse this list for further reference.

What are the most common smells you have seen on C# code? How did you fix them?

© Stack Overflow or respective owner

Related posts about c#

.NET WebRequest.PreAuthenticate not quite what it sounds like

as seen on West-Wind - Search for 'West-Wind'
I’ve run into the problem a few times now: How to pre-authenticate .NET WebRequest calls doing an HTTP call to the server – essentially send authentication credentials on the very first request instead of waiting for a server challenge first? At first glance this sound like it should be easy:… >>> More
HttpWebRequest and Ignoring SSL Certificate Errors

as seen on West-Wind - Search for 'West-Wind'
Man I can't believe this. I'm still mucking around with OFX servers and it drives me absolutely crazy how some these servers are just so unbelievably misconfigured. I've recently hit three different 3 major brokerages which fail HTTP validation with bad or corrupt certificates at least according to… >>> More
The dynamic Type in C# Simplifies COM Member Access from Visual FoxPro

as seen on West-Wind - Search for 'West-Wind'
I’ve written quite a bit about Visual FoxPro interoperating with .NET in the past both for ASP.NET interacting with Visual FoxPro COM objects as well as Visual FoxPro calling into .NET code via COM Interop. COM Interop with Visual FoxPro has a number of problems but one of them at least got a lot… >>> More
Dynamic Type to do away with Reflection

as seen on West-Wind - Search for 'West-Wind'
The dynamic type in C# 4.0 is a welcome addition to the language. One thing I’ve been doing a lot with it is to remove explicit Reflection code that’s often necessary when you ‘dynamically’ need to walk and object hierarchy. In the past I’ve had a number of ReflectionUtils that used string based expressions… >>> More
Finding a Relative Path in .NET

as seen on West-Wind - Search for 'West-Wind'
Here’s a nice and simple path utility that I’ve needed in a number of applications: I need to find a relative path based on a base path. So if I’m working in a folder called c:\temp\templates\ and I want to find a relative path for c:\temp\templates\subdir\test.txt I want to receive back subdir\test… >>> More

Related posts about code-review

code review: Is it subjective or objective(quantifiable) ?

as seen on Stack Overflow - Search for 'Stack Overflow'
I am putting together some guidelines for code reviews. We do not have one formal process yet, and trying to formalize it. And our team is geographically distributed We are using TFS for source control (used it for tasks/bug tracking/project management as well, but migrated that to JIRA) with VS2008… >>> More
What's a good desktop-based code review tool?

as seen on Stack Overflow - Search for 'Stack Overflow'
Is there a desktop-based tool that's used for code reviews or do we just have to print out the code and mark it up by hand? >>> More
Using commit monitors as a form of code review

as seen on Stack Overflow - Search for 'Stack Overflow'
I'm working in a small company - four developers, working on a variety of projects. We've been looking at what we can do as cost-effective methods of process improvement, and an idea came up. Given what we do, we often have single developers working on parts of a system, independently of the other… >>> More
VS 2012 Code Review – Before Check In OR After Check In?

as seen on Geeks with Blogs - Search for 'Geeks with Blogs'
“Is Code Review Important and Effective?” There is a consensus across the industry that code review is an effective and practical way to collar code inconsistency and possible defects early in the software development life cycle. Among others some of the advantages of code reviews are, Bugs… >>> More
Why should i depend on a tool for my code review?

as seen on Stack Overflow - Search for 'Stack Overflow'
I have done with my web application. Now I am into code review phase. I have looked for some tools for code review in StackOverflow. But my question is: Why should I depend on a tool for my code review? >>> More