Should I send patch against 2-3-stable or master

Posted by Nadal on Stack Overflow See other posts from Stack Overflow or by Nadal
Published on 2010-04-19T15:28:13Z Indexed on 2010/12/21 5:21 UTC
Read the original article Hit count: 202

Filed under:

ruby-on-rails

|

contribute

I am trying to find a way to contribute back to rails. I was thinking I should validate if this patch https://rails.lighthouseapp.com/projects/8994/tickets/4154-expires_now-broken works or not.

I was able to validate the problem. The problem still exists in 2.3.5 and in 2-3-stable branch of rails.

I was not able to apply his patch at 2-3-stable branch of rails . Also the patch failed for master branch.

Looked at the diff and manually changed the code and the new code solves the bug.

Now if I want to attach my patch to the ticket should I create my patch against 2-3-stable branch or master branch?

I believe master is more closely aligned with rails3 changes.

© Stack Overflow or respective owner

Related posts about ruby-on-rails

Ruby on Rails - How can I start? [closed]

as seen on Programmers - Search for 'Programmers'
I have misconception in understanding the relationship between Ruby language and Ruby on Rails Framework. Because of 'I am an absolute beginner' in web development I have no idea if I have to grasp the fundamentals of Ruby before I go with Ruby on Rails! I also want to ask who is behind both Ruby… >>> More
DES3 decryption in Ruby on Rails

as seen on Stack Overflow - Search for 'Stack Overflow'
My RoR server receives a string, that was encrypted in C++ application using des3 with base64 encoding The cipher object is created so: cipher = OpenSSL::Cipher::Cipher::new("des3") cipher.key = key_str cipher.iv = iv_str key_str and iv_str: are string representations of key and initialization… >>> More
Ruby on rails: Image downloads with Authentication/Authorization/Time outs

as seen on Stack Overflow - Search for 'Stack Overflow'
Hi Guys, I'm having few doubts on implementing file downloads. I'm creating an app where I use attachment_fu with Amazon s3 to upload files. Things are working pretty well so far on uploading side. Now its the time to start the file downloads. Here is what I need, a logged in user search and browse… >>> More
Ruby on Rails deployment, on "thin" server with lot of attachments

as seen on Stack Overflow - Search for 'Stack Overflow'
A lot of PDFs are stored inside MySQL as a BLOB field for each PDF file. The average file size is 500K each. The Rails app will stream the :binary data as file downloads, where there is a user click on the download link. Assume there is a maximum of 5 users downloading 5 PDFs concurrently, what… >>> More
Apply Behavior Driven Development to Ruby on Rails with Rspec

as seen on Internet.com - Search for 'Internet.com'
Applying the Behavior Driven Development (BDD) methodology to your Rails development takes you beyond traditional Test Driven Development. Learn how to do it with the Ruby-based BDD framework RSpec. >>> More

Related posts about contribute

Linux users contribute twice as much as Windows users

as seen on Internet.com - Search for 'Internet.com'
<b>Wolfire Blog:</b> "We've always advocated cross-platform development -- in fact, last year, we wrote a post explaining why you should support Mac OS X and Linux" >>> More
Microsoft Will Contribute to the Development of the jQuery JavaScript Library

as seen on ASP.NET - Search for 'ASP.NET'
Scott Guthrie announced at MIX 2010 today that Microsoft is investing resources to contribute to the development of the jQuery JavaScript Library and working to provide better interoperability between ASP.NET and jQuery. >>> More
Do you contribute to open-source software?

as seen on Programmers - Search for 'Programmers'
Recently John Resig (creator of the jQuery library) wrote on his twitter that "When it comes to hiring, I'll take a Github commit log over a resume any day.". As much as I respect that (motivating developers to give back to the community), it also puzzles me, as not all of us have the opportunity… >>> More
Reasons Why You Don't Contribute To Open-Source Software

as seen on Internet.com - Search for 'Internet.com'
<b>Phoronix:</b> "Over on the GCC mailing list is a rather lively discussion (especially for being a Friday evening) that only started earlier today...A developer is asking why you don't participate in contributing to GCC? " >>> More
Can't create site connection in Contribute. Adminstrator account removed from domain

as seen on Pro Webmasters - Search for 'Pro Webmasters'
I have been tasked with administering several sites through Contribute. The previous administrator has since left and his domain account was removed. I believe I had been set up as an additional admin on these sites previously. However, when I attempt to create a connection through "My Connections"… >>> More