Criticise/Recommendations for my code

Posted by aLk on Stack Overflow See other posts from Stack Overflow or by aLk
Published on 2010-12-25T03:35:03Z Indexed on 2010/12/25 3:54 UTC
Read the original article Hit count: 186

Filed under:

Before i go any further it would be nice to know if there is any major design flaws in my program so far. Is there anything worth changing before i continue?

Model

package model;

import java.sql.*;
import java.util.*;

public class MovieDatabase {
    @SuppressWarnings({ "rawtypes", "unchecked" })
    public List queryMovies() throws SQLException {
        Connection connection = null;
        java.sql.Statement statement = null;
        ResultSet rs = null;
        List results = new ArrayList();

        try {
            DriverManager.registerDriver(new com.mysql.jdbc.Driver());
            connection = DriverManager.getConnection("jdbc:mysql://localhost:3306/test", "root", "password");           
            statement = connection.createStatement();
            String query = "SELECT * FROM movie";
            rs = statement.executeQuery(query);

            while(rs.next()) {
                MovieBean bean = new MovieBean();
                bean.setMovieId(rs.getInt(1));
                bean.setTitle(rs.getString(2));
                bean.setYear(rs.getInt(3));
                bean.setRating(rs.getInt(4));
                results.add(bean);
            }
        } catch(SQLException e) {

        }
        return results;
    }
}

Servlet

public class Service extends HttpServlet {

    @SuppressWarnings("rawtypes")
    protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
        response.setContentType("text/html");
        PrintWriter out = response.getWriter();
        out.println("Movies!");
        MovieDatabase movies = new MovieDatabase();

        try {
            List results = movies.queryMovies();
            Iterator it = results.iterator();

            while(it.hasNext()) {
                MovieBean movie = new MovieBean();
                movie = (MovieBean)it.next();
                out.println(movie.getYear());
            }
        }
        catch(SQLException e) {

        }

    }
}

Bean

package model;

@SuppressWarnings("serial")
public class MovieBean implements java.io.Serializable {

    protected int movieid;
    protected int rating;
    protected int year;
    protected String title;

    public MovieBean() {

    }

    public void setMovieId(int movieidVal) {
        movieid = movieidVal;
    }

    public void setRating(int ratingVal) {
        rating = ratingVal;
    }

    public void setYear(int yearVal) {
        year = yearVal;
    }

    public void setTitle(String titleVal) {
        title = titleVal;
    }

    public int getMovieId() {
        return movieid;
    }

    public int getRating() {
        return rating;
    }

    public int getYear() {
        return year;
    }

    public String getTitle() {
        return title;
    }

}

© Stack Overflow or respective owner

Related posts about java