How to tell your boss that his programming style is really bad?

Posted by Roflcoptr on Programmers See other posts from Programmers or by Roflcoptr
Published on 2011-02-09T14:43:36Z Indexed on 2011/02/09 15:33 UTC
Read the original article Hit count: 300

Filed under:

work-environment

|

programming-practices

|

boss

I'm a student and in my spare time I'm working for a big enterprise as Java developer. The job is good, but the problem is, my boss is writing very strange code. I don't want to complain, but some issues are in my opinion really strange. For example:

he doesn't know any booleans. All boolean conditions are Strings called "YesOrNo" and then in the condition he uses if (YesOrNo == "Yes")
there are a lot of very strange characters in method names and variables like é õ ô or è
all loops are infinite loops in the style of for(;;). Then at the end of the loop the condition is tested and if the conditions is fulfilled break; is called.

I don't now if I should tell him that I think this isn't a good practice, since he is my boss and decides how and what to do. On the other hand some of this examples are really very weird.

Any hints how to cope with? And is this only me who thinks that's bad style?

© Programmers or respective owner

Related posts about work-environment

How to improve the programmers work environment

as seen on Programmers - Search for 'Programmers'
I manage a team of six programmers, working on diverse systems. We work in an open plan office, with members sitting in cubicles. A lot of people on these forums are big on private offices, but that is not an option for me. But I was wondering if there were ideas for other ways to improve and energize… >>> More
Structured work-environment in comparison to an unstructured one [closed]

as seen on Programmers - Search for 'Programmers'
I was asked in an interview whether the environment I work in is structured or unstructured. I believe at their end it is unstructured. How will my answer hurt or help my chances at the company ? And what is it intent of this question ? The place where I work it is structured in terms of the technologies… >>> More
How to deal with a 'public' work environment?

as seen on Programmers - Search for 'Programmers'
In the last 6 months, I have changed desks at my office 4 times. I don't mind, as it's due to expansion of the company and acquiring new office space and getting everybody settled. However, I truly miss the semi-private office I sat in 2 desks ago. I am now sitting in a large room with a number of… >>> More
Automatic desktop/work environment setup

as seen on Ask Ubuntu - Search for 'Ask Ubuntu'
I have this strange thing I am trying to do, so before I jump into it I was curious if someone knows about existing solution or maybe have an advice as far as implementation. I run a small software company and as it happens I often do very different type of work. When I do coding for Java project… >>> More
Result Only Work Environment

as seen on Stack Overflow - Search for 'Stack Overflow'
Hello, I would like to set up a ROWE for my dev team: Result Only Work Environment. Basically, people work how they want, when they want, as long as the work gets done. This environment has been a huge success for Best Buy: increasing productivity and reducing turnover. Does anyone have any advice… >>> More

Related posts about programming-practices

programming practices starting

as seen on Programmers - Search for 'Programmers'
I have taken my major as computer science and Engineering and I am really confused at this moment. My first course was about learning C and C++ and I learned the basics of those. Now I am really confused what to do next. Some says I should practice algorithms and do contests in ACM-ICPC for now… >>> More
Are `break` and `continue` bad programming practices?

as seen on Programmers - Search for 'Programmers'
My boss keeps mentioning nonchalantly that bad programmers use break and continue in loops. I use them all the time because they make sense; let me show you the inspiration: function verify(object) { if (object->value < 0) return false; if (object->value > object->max_value)… >>> More
Why is C++ backward compatibility important / necessary?

as seen on Programmers - Search for 'Programmers'
As far as understand it is a well-established opinion within the C++ community that C is an obsolete language that was useful 20 years ago but cannot support many modern good programming practices, or even encourages bad practices; certain features that were typical of C++ (C with classes) during… >>> More
Any task-control algorithms programming practices?

as seen on Stack Overflow - Search for 'Stack Overflow'
Hi, I was just wondering if there's any field which concerns the task-control programming (or at least that's the way I call it). For a better explanation of task-control consider the following scenario: An application (master-thread) waits for a command - which might be a particular action or… >>> More
displaying python's autodoc to the user (python 3.3)

as seen on Programmers - Search for 'Programmers'
I'm writing a simple command line math game, and I'm using python's autodoc for my math algorithms to help me remember, for example, what a proth number is while i'm writing the algorithm, but later on I'll want to tell that information to the user as well, so they'll know what the answer was. So… >>> More