How important is positive feedback in code reviews?

Posted by c_maker on Programmers See other posts from Programmers or by c_maker
Published on 2012-10-11T14:11:26Z Indexed on 2012/10/11 15:47 UTC
Read the original article Hit count: 428

Filed under:

code-reviews

Is it important to point out the good parts of the code during a code review and the reasons why it is good? Positive feedback might be just as useful for the developer being reviewed and for the others that participate in the review.

We are doing reviews using an online tool, so developers can open reviews for their committed code and others can review their code within a given time period (e.g. 1 week). Others can comment on the code or other reviewer's comments.

Should there be a balance between positive and negative feedback?

Related posts about code-reviews

How should code reviews be Carried Out?

as seen on Programmers - Search for 'Programmers'
My previous question has to do with how to advance code reviews among the developers. Here I am interested in how a code review session should be carried out, so that both the reviewer and reviewed are feeling comfortable with it. I have done some code reviews before and the experience has been… >>> More
How important is positive feedback in code reviews?

as seen on Programmers - Search for 'Programmers'
Is it important to point out the good parts of the code during a code review and the reasons why it is good? Positive feedback might be just as useful for the developer being reviewed and for the others that participate in the review. We are doing reviews using an online tool, so developers can open… >>> More
When to do code reviews when doing continuous integration?

as seen on Programmers - Search for 'Programmers'
We are trying to switch to a continuous integration environment but are not sure when to do code reviews. From what I've read of continuous integration, we should be attempting to check in code as often as multiple times a day. I assume, this even means for features that are not yet complete. So… >>> More
How to review code that you do not understand?

as seen on Programmers - Search for 'Programmers'
I have been given the role to improve development in our company. The first thing I wanted to start was code reviews since that has never been done here before. There are 3 programmers in our company. I am a web programmer, my known languages are mainly PHP, ActionScript and JavaScript. The other… >>> More
Are there code reviews in opensource projects? If so, what tools are used to do this?

as seen on Programmers - Search for 'Programmers'
I know there is a big push for code reviews in commercial development. However, are code reviews used in open source software or is based on trust? If so, then how are they performed? [Is it a delayed commit, "a pre commit environment", is there a tool that allows for the patch to be sent to another… >>> More

Developer IT