Django FileField not saving to upload_to location

Posted by Erik on Stack Overflow See other posts from Stack Overflow or by Erik
Published on 2012-10-23T22:55:35Z Indexed on 2012/10/24 5:04 UTC
Read the original article Hit count: 452

I have an Attachment model that has a FileField in a Django 1.4.1 app. This FileField has a callable upload_to parameter which, per the Django docs should be called when the form (and therefore the model) is saved.

When I run FormTest below, the upload_to callable is never called and the file therefore does not appear in the location provided by the upload_to method. What am I doing wrong?

Notice that in the passing tests in ModelTest (also below), the upload_to method works as expected.

Test:

from core.forms.attachments import AttachmentForm
from django.test import TestCase
import unittest
from django.core.files.uploadedfile import SimpleUploadedFile
from django.core.files.storage import default_storage

def suite():
    return unittest.TestSuite(
        [
            unittest.TestLoader().loadTestsFromTestCase(FormTest),
        ]
    )

class FormTest(TestCase):
    def test_form_1(self):
        filename = 'filename'
        f = file(filename)
        data = {'name':'name',}
        file_data = {'attachment_file':SimpleUploadedFile(f.name,f.read()),}
        form = AttachmentForm(data=data,files=file_data)
        self.assertTrue(form.is_valid())
        attachment = form.save()
        root_directory = 'attachments'
        upload_location = root_directory + '/' + attachment.directory + '/' + filename
        self.assertTrue(attachment.attachment_file)                 # Fails
        self.assertTrue(default_storage.exists(upload_location))    # Fails

Attachment Model:

from django.db import models
from parent_mixins import Parent_Mixin
import uuid
from django.db.models.signals import pre_delete,pre_save
from dirtyfields import DirtyFieldsMixin

def upload_to(instance,filename):
    return 'attachments/' + instance.directory + '/' + filename

def uuid_directory_name():
    return uuid.uuid4().hex

class Attachment(DirtyFieldsMixin,Parent_Mixin,models.Model):
    attachment_file = models.FileField(blank=True,null=True,upload_to=upload_to)
    directory = models.CharField(blank=False,default=uuid_directory_name,null=False,max_length=32)
    name = models.CharField(blank=False,default=None,null=False,max_length=128)

    class Meta:
        app_label = 'core'

    def __str__(self):
        return unicode(self).encode('utf-8')

    def __unicode__(self):
        return unicode(self.name)

    @models.permalink
    def get_absolute_url(self):
        return('core_attachments_update',(),{'pk': self.pk})

    # def save(self,*args,**kwargs):
    #     super(Attachment,self).save(*args,**kwargs)

def pre_delete_callback(sender, instance, *args, **kwargs):
    if not isinstance(instance, Attachment): return
    if not instance.attachment_file: return
    instance.attachment_file.delete(save=False)

def pre_save_callback(sender, instance, *args, **kwargs):
    if not isinstance(instance, Attachment): return
    if not instance.attachment_file: return
    if instance.is_dirty():
        dirty_fields = instance.get_dirty_fields()
        if 'attachment_file' in dirty_fields:
            old_attachment_file = dirty_fields['attachment_file']
            old_attachment_file.delete()

pre_delete.connect(pre_delete_callback)
pre_save.connect(pre_save_callback)

Attachment Form:

from ..models.attachments import Attachment
from crispy_forms.helper import FormHelper
from crispy_forms.layout import Div,Layout,HTML,Field,Fieldset,Button,ButtonHolder,Submit
from django import forms

class AttachmentFormHelper(FormHelper):
    form_tag=False

    layout = Layout(
        Div(
            Div(
                Field('name',css_class='span4'),
                Field('attachment_file',css_class='span4'),
                css_class='span4',
            ),
            css_class='row',
        ),
    )

class AttachmentForm(forms.ModelForm):
    helper = AttachmentFormHelper()

    class Meta:
        fields=('attachment_file','name')
        model = Attachment

class AttachmentInlineFormHelper(FormHelper):
    form_tag=False
    form_style='inline'

    layout = Layout(
        Div(
            Div(
                Field('name',css_class='span4'),
                Field('attachment_file',css_class='span4'),
                Field('DELETE',css_class='span4'),
                css_class='span4',
            ),
            css_class='row',
        ),
    )

class AttachmentInlineForm(forms.ModelForm):
    helper = AttachmentInlineFormHelper()

    class Meta:
        fields=('attachment_file','name')
        model = Attachment

UPDATE

I also do testing on the Attachment model class with these unit tests -- which all pass:

from core.models.attachments import Attachment
from core.models.attachments import upload_to
from django.test import TestCase
import unittest
from django.core.files.storage import default_storage
from django.core.files.base import ContentFile

def suite():
    return unittest.TestSuite(
        [
            unittest.TestLoader().loadTestsFromTestCase(ModelTest),
        ]
    )

class ModelTest(TestCase):
    def test_model_minimum_fields(self):
        attachment = Attachment(name='name')
        attachment.attachment_file.save('test.txt',ContentFile("hello world"))
        attachment.save()
        self.assertEqual(str(attachment),'name')
        self.assertEqual(unicode(attachment),'name')
        self.assertTrue(attachment.directory)

    # def test_model_full_fields(self):
    #     attachment = Attachment()
    #     attachement.save()

    def test_file_operations_basic(self):
        root_directory = 'attachments'
        filename = 'test.txt'
        attachment = Attachment(name='name')
        attachment.attachment_file.save(filename,ContentFile('test'))
        attachment.save()
        upload_location = root_directory + '/' + attachment.directory + '/' + filename
        self.assertEqual(upload_to(attachment,filename),upload_location)
        self.assertTrue(default_storage.exists(upload_location))

    def test_file_operations_delete(self):
        root_directory = 'attachments'
        filename = 'test.txt'
        attachment = Attachment(name='name')
        attachment.attachment_file.save(filename,ContentFile('test'))
        attachment.save()
        upload_location = upload_to(attachment,filename)
        attachment.delete()
        self.assertFalse(default_storage.exists(upload_location))

    def test_file_operations_change(self):
        root_directory = 'attachments'
        filename_1 = 'test_1.txt'
        attachment = Attachment(name='name')
        attachment.attachment_file.save(filename_1,ContentFile('test'))
        attachment.save()
        upload_location_1 = upload_to(attachment,filename_1)
        self.assertTrue(default_storage.exists(upload_location_1))

        filename_2 = 'test_2.txt'
        attachment.attachment_file.save(filename_2,ContentFile('test'))
        attachment.save()
        upload_location_2 = upload_to(attachment,filename_2)
        self.assertTrue(default_storage.exists(upload_location_2))
        self.assertFalse(default_storage.exists(upload_location_1))

© Stack Overflow or respective owner

Related posts about django

Related posts about django-models