How do I correct feature envy in this case?
- by RMorrisey
I have some code that looks like:
class Parent {
private Intermediate intermediateContainer;
public Intermediate getIntermediate();
}
class Intermediate {
private Child child;
public Child getChild() {...}
public void intermediateOp();
}
class Child {
public void something();
public void somethingElse();
}
class Client {
private Parent parent;
public void something() {
parent.getIntermediate().getChild().something();
}
public void somethingElse() {
parent.getIntermediate().getChild().somethingElse();
}
public void intermediate() {
parent.getIntermediate().intermediateOp();
}
}
I understand that is an example of the "feature envy" code smell. The question is, what's the best way to fix it? My first instinct is to put the three methods on parent:
parent.something();
parent.somethingElse();
parent.intermediateOp();
...but I feel like this duplicates code, and clutters the API of the Parent class (which is already rather busy).
Do I want to store the result of getIntermediate(), and/or getChild(), and keep my own references to these objects?
