How can I coordinate code review tool and RCS (specifically git)
- by Chris Nelson
We're committed to git for code management. We're trying to find a tool that will help us systematize code reviews. We're considering Gerrit and Code Collaborator but would welcome other suggestions.
We're having a problem answering the question, "How do we know every commit was reviewed?" (Or "What commits have yet to be reviewed?")
One answer would be to submit every commit or every push for review and track incomplete reviews in the review tool. I'm not entirely happy with relying on a another tool -- especially if it's not open source -- to tell us this.
What seems to be a better answer is to rely on sign offs in git (e.g., "Signed-off-by: Chris Nelson") and use a hook in the review tool to sign off commits on behalf of the reviewer. And advantage of this is if we use some other review mechanism for some commits, we have just one place to look for results. One problem with this is that we can't require review before push because the review tool is unlikely to have access to the developer's private repository clone to add the sign-off.
Any ideas on integrating code review with code management to achieve ease of use and high visibility of unreviewed changes?
