What is your best example of a violation of the Single Responsibility Principle?

Posted by Jon Kruger on Stack Overflow See other posts from Stack Overflow or by Jon Kruger
Published on 2009-08-30T18:57:01Z Indexed on 2010/05/23 2:20 UTC
Read the original article Hit count: 321

Filed under:

solid

|

srp

I'm looking for some good examples of code that violates the Single Responsibility Principle. Don't show me any examples from Uncle Bob's books or web sites since those are plastered all over the internet, like this one:

interface Modem
{
    public void dial(String pno);
    public void hangup();
    public void send(char c);
    public char recv();
}

© Stack Overflow or respective owner

Related posts about solid

Are SOLID principles really solid?

as seen on Stack Overflow - Search for 'Stack Overflow'
The first pattern stands for this acronym is SRP. Here is a quote. the single responsibility principle states that every object should have a single responsibility, and that responsibility should be entirely encapsulated by the class. That's is simple and clear till we start to code… >>> More
Twitter Bootstrap styling conflicts with plug-ins like jqGrid and other third part libraries

as seen on Geeks with Blogs - Search for 'Geeks with Blogs'
Issues:The concern is that the Twitter Bootstrap framework is that some of their css selectors are simply too generic and have incompatibility issues and conflicts with most third party plug-ins and css libraries, like jQuery-UI and jqGrid.My most pressing concern is only with the generic selector… >>> More
border:2px solid red VS border:2px red solid

as seen on Stack Overflow - Search for 'Stack Overflow'
Are both method valid? both works same. border:2px solid red; and border:2px red solid; >>> More
Solid State Drives Find Way to Enterprise Apps

as seen on Internet.com - Search for 'Internet.com'
SSDs can improve database and file system performance, but various issues msut be addressed to make the most of the pricey drives. >>> More
"Building on a Solid Foundation"

as seen on Oracle Technology Network - Search for 'Oracle Technology Network'
Designing the right IT infrastructure is a critical part of ensuring application availability and performance. See how companies rely on an Oracle grid infrastructure—including Oracle Database and Oracle Real Application Clusters—to provide a solid yet flexible base for their applications. >>> More

Related posts about srp

Aren't Information Expert / Tell Don't Ask at odds with Single Responsibility Principle?

as seen on Stack Overflow - Search for 'Stack Overflow'
It is probably just me, which is why I'm asking the question. Information Expert, Tell Don't Ask, and SRP are often mentioned together as best practices. But I think they are at odds. Here is what I'm talking about: Code that favors SRP but violates Tell Don't Ask, Info Expert: Customer bob = .… >>> More
How do I prove or disprove "god" objects are wrong?

as seen on Programmers - Search for 'Programmers'
Problem Summary: Long story short, I inherited a code base and an development team I am not allowed to replace and the use of God Objects is a big issue. Going forward, I want to have us re-factor things but I am getting push-back from the teams who want to do everything with God Objects "because… >>> More
IValidatableObject vs Single Responsibility

as seen on Programmers - Search for 'Programmers'
I like the extnesibility point of MVC, allowing view models to implement IValidatableObject, and add custom validation. I try to keep my Controllers lean, having this code be the only validation logic: if (!ModelState.IsValid) return View(loginViewModel); For example a login view model implements… >>> More
Design patterns to avoiding breaking the SRP while performing heavy data logging

as seen on Programmers - Search for 'Programmers'
A class that performs both computations and data logging seems to have at least two responsibilities. Given a system for which the specifications require heavy data logging, what kind of design patterns or architectural patterns can be used to avoid bloating all the classes with logging calls every… >>> More
Composite-like pattern and SRP violation

as seen on Programmers - Search for 'Programmers'
Recently I've noticed myself implementing pattern similar to the one described below. Starting with interface: public interface IUserProvider { User GetUser(UserData data); } GetUser method's pure job is to somehow return user (that would be an operation speaking in composite terms). There… >>> More