What should come first: testing or code review?

Posted by Silver Light on Programmers See other posts from Programmers or by Silver Light
Published on 2011-02-11T16:09:39Z Indexed on 2011/02/11 23:33 UTC
Read the original article Hit count: 298

Filed under:

testing

|

code-reviews

Hello!

I'm quite new to programming design patterns and life cycles and I was wondering, what should come first, code review or testing, regarding that those are done by separate people?

From the one side, why bother reviewing code if nobody checked if it even works? From the other, some errors can be found early, if you do the review before testing.

Which approach is recommended and why?

Thank you!

© Programmers or respective owner

Related posts about testing

Automated unit testing, integration testing or acceptance testing

as seen on Programmers - Search for 'Programmers'
TDD and unit testing seems to be the big rave at the moment. But it is really that useful compared to other forms of automated testing? Intuitively I would guess that automated integration testing is way more useful than unit testing. In my experience the most bugs seems to be in the interaction… >>> More
Modifying a HTML page to fix several "bugs" add a function to next/previous on a option dropdown

as seen on Stack Overflow - Search for 'Stack Overflow'
SOF, I've got a few problems plaguing me at the moment and am wondering if anyone could assist me with them. I'm trying to get Next Class | Previous Class to act as buttons so that when Next Class is clicked it will go to the next item in the dropdown list and for previous it would go to back one… >>> More
Automation testing tool for Regression testing of desktop application

as seen on Stack Overflow - Search for 'Stack Overflow'
Hi I am working on a desktop application which uses Infragistic grids. We need to automate the regression tests for same. QTP alone does not support this, we need to buy new plug in for same which my company is not very much interested in. Do we have any open source tool for automating regression… >>> More
Oracle Functional Testing Suite Advanced Pack for Oracle EBS Now Available

as seen on Oracle Blogs - Search for 'Oracle Blogs'
There’s new news about automated testing of E-Business Suite using the Oracle Application Testing Suite, a.k.a, “OATS”. E-Business Suite Development is pleased to announce the availability of the new Oracle Functional Testing Suite Advanced Pack for Oracle E-Business Suite. The new pack, available… >>> More
Do You Know How OUM defines the four, basic types of business system testing performed on a project? Why not test your knowledge?

as seen on Oracle Blogs - Search for 'Oracle Blogs'
Testing is perhaps the most important process in the Oracle® Unified Method (OUM). That makes it all the more important for practitioners to have a common understanding of the various types of functional testing referenced in the method, and to use the proper terminology when communicating with each… >>> More

Related posts about code-reviews

How should code reviews be Carried Out?

as seen on Programmers - Search for 'Programmers'
My previous question has to do with how to advance code reviews among the developers. Here I am interested in how a code review session should be carried out, so that both the reviewer and reviewed are feeling comfortable with it. I have done some code reviews before and the experience has been… >>> More
How important is positive feedback in code reviews?

as seen on Programmers - Search for 'Programmers'
Is it important to point out the good parts of the code during a code review and the reasons why it is good? Positive feedback might be just as useful for the developer being reviewed and for the others that participate in the review. We are doing reviews using an online tool, so developers can open… >>> More
When to do code reviews when doing continuous integration?

as seen on Programmers - Search for 'Programmers'
We are trying to switch to a continuous integration environment but are not sure when to do code reviews. From what I've read of continuous integration, we should be attempting to check in code as often as multiple times a day. I assume, this even means for features that are not yet complete. So… >>> More
How to review code that you do not understand?

as seen on Programmers - Search for 'Programmers'
I have been given the role to improve development in our company. The first thing I wanted to start was code reviews since that has never been done here before. There are 3 programmers in our company. I am a web programmer, my known languages are mainly PHP, ActionScript and JavaScript. The other… >>> More
Are there code reviews in opensource projects? If so, what tools are used to do this?

as seen on Programmers - Search for 'Programmers'
I know there is a big push for code reviews in commercial development. However, are code reviews used in open source software or is based on trust? If so, then how are they performed? [Is it a delayed commit, "a pre commit environment", is there a tool that allows for the patch to be sent to another… >>> More