How to code review without offending other developers [duplicate]
- by Justin984
This question already has an answer here:
How to deal with someone who dislikes the idea of code reviews?
6 answers
How can I tactfully suggest improvements to others' badly designed code during review?
14 answers
How do I approach a coworker about his or her code quality?
12 answers
I work on a team that does frequent code reviews. But it seems like more of a formality than anything.
No one really points out problems in the code for fear of offending other developers. The few times I've tried to ask for changes were met with very defensive and reluctant attitudes.
This is of course not good. Not only are we spending the time to code review, but we're getting literally zero value from it. Is this an issue that needs to be addressed by individual developers, or are there techniques for suggesting changes without stepping on other people's toes?