Auto injecting logger with guice
- by koss
With reference to Guice's custom injections article, its TypeListener performs a check for InjectLogger.class annotation - which can be optional. Removing that check will inject to all Logger.class types.
class Log4JTypeListener implements TypeListener {
public <T> void hear(TypeLiteral<T> typeLiteral, TypeEncounter<T> typeEncounter) {
for (Field field : typeLiteral.getRawType().getDeclaredFields()) {
if (field.getType() == Logger.class
&& field.isAnnotationPresent(InjectLogger.class)) {
typeEncounter.register(new Log4JMembersInjector<T>(field));
}
}
}
}
I'm tempted to remove "&& field.isAnnotationPresent(InjectLogger.class)" from the listener.
If we're using Guice to inject all instances of our Logger, is there any reason not to do it automatically (without need to annotate)?
