is it better to test if a function is needed inside or outside of it?
- by b0x0rz
what is the best practice? call a function then return if you test for something, or test for something then call?
i prefer the test inside of function because it makes an easier viewing of what functions are called.
for example:
protected void Application_BeginRequest(object sender, EventArgs e)
{
this.FixURLCosmetics();
}
and
private void FixURLCosmetics()
{
HttpContext context = HttpContext.Current;
if (!context.Request.HttpMethod.ToString().Equals("GET", StringComparison.OrdinalIgnoreCase))
{
// if not a GET method cancel url cosmetics
return;
};
string url = context.Request.RawUrl.ToString();
bool doRedirect = false;
// remove > default.aspx
if (url.EndsWith("/default.aspx", StringComparison.OrdinalIgnoreCase))
{
url = url.Substring(0, url.Length - 12);
doRedirect = true;
}
// remove > www
if (url.Contains("//www"))
{
url = url.Replace("//www", "//");
doRedirect = true;
}
// redirect if necessary
if (doRedirect)
{
context.Response.Redirect(url);
}
}
is this good:
if (!context.Request.HttpMethod.ToString().Equals("GET", StringComparison.OrdinalIgnoreCase))
{
// if not a GET method cancel url cosmetics
return;
};
or should that test be done in Application_BeginRequest?
what is better?
thnx
